Return an error when we fail to instantiate the server #3642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Nov 23, 2022
MichaelSnowden
force-pushed
the
create-server-err
branch
3 times, most recently
from
7517871 to
1214749
Compare
MichaelSnowden
force-pushed
the
create-server-err
branch
from
1214749 to
8c334bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We now return an error when FX fails to build the server.
Why?
I made this change so that we can verify that a new server can be instantiated for all services without failing, but that failures will be detected.
How did you test it?
I tested this by adding unit tests for the happy path and an error path (invalid config path). I also ran it locally with race detection on.
Potential risks
This is a new error message, and some invalid configs may trigger this error path when they didn't before.
Is hotfix candidate?
No.