Fix ES bulk processor commit timeout #3696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/tune-es-bulk-processor
branch
from
d0da87b
to
a5aa26e
Compare
alexshtin
changed the title
alexshtin
force-pushed
the
feature/tune-es-bulk-processor
branch
2 times, most recently
from
261cabf
to
51fcc24
Compare
rodrigozhou
approved these changes
Dec 9, 2022
Comment on lines
202
to
203
| p.metricsHandler.Histogram(metrics.ElasticsearchBulkProcessorQueuedRequests.GetMetricName(), metrics.ElasticsearchBulkProcessorBulkSize.GetMetricUnit()). | ||
| Record(int64(p.mapToAckFuture.Len() - len(requests))) | ||
| Record(int64(p.mapToAckFuture.Len())) |
There was a problem hiding this comment.
What is this metric supposed to mean? Number of queued requests?
Wouldn't it make more sense to call this after the queue size changes? Like, in bulkAfterAction?
There was a problem hiding this comment.
Like how many documents are still waiting to be flushed. I like the idea of moving this to bulkAfterAction.
common/persistence/visibility/store/elasticsearch/visibility_store.go
Outdated
Show resolved
Hide resolved
alexshtin
force-pushed
the
feature/tune-es-bulk-processor
branch
3 times, most recently
from
51659ca
to
59250e2
Compare
yycptt
approved these changes
Dec 13, 2022
alexshtin
force-pushed
the
feature/tune-es-bulk-processor
branch
from
66dde25
to
20fc1b9
Compare
yycptt
pushed a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Increased default number of bulk processor workers from 1 to 2. Rationale: it should help with commit latency during traffic spikes and with "wait add" latency.This goes to Increase default number of Elasticsearch bulk processor workers to 2 #3738 instead.elasticsearch_bulk_processor_queued_requestsmetric is emitted. It now shows number of pending requests after current bulk is processed.Why?
Fixing bugs, improving overall ES write latency.
How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
Yes.