Add speculative workflow task #3768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcshane
reviewed
Jan 3, 2023
| google.protobuf.Timestamp workflow_task_original_scheduled_time = 30 [(gogoproto.stdtime) = true]; | ||
| string workflow_task_request_id = 31; | ||
| bool workflow_task_speculative = 68; |
There was a problem hiding this comment.
Would we be better served with an enum here? We could include normal and transient WFT types as well as others in the future?
alexshtin
force-pushed
the
feature/speculative-wt
branch
from
2d402a5
to
1d1262b
Compare
Disable speculative WT restoration
alexshtin
force-pushed
the
feature/speculative-wt
branch
from
1d1262b
to
a14775c
Compare
mmcshane
approved these changes
Jan 6, 2023
| @@ -465,7 +477,7 @@ func (m *workflowTaskStateMachine) AddWorkflowTaskCompletedEvent( | |||
|
|
|||
| // Capture if WorkflowTaskScheduled and WorkflowTaskStarted events were created | |||
| // before calling m.beforeAddWorkflowTaskCompletedEvent() because it will delete workflow task info from mutable state. | |||
| workflowTaskScheduledStartedEventsCreated := !m.ms.IsTransientWorkflowTask() | |||
| workflowTaskScheduledStartedEventsCreated := !m.ms.IsTransientWorkflowTask() && workflowTask.Type != enumsspb.WORKFLOW_TASK_TYPE_SPECULATIVE | |||
There was a problem hiding this comment.
Not necessary for this PR but this might be a good thing to encapsulate into executionInfo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add speculative workflow task.
Why?
Speculative workflow task is similar to transient but it can be created even for the first attempt. Speculative workflow task is designed to be not persisted in database. It doesn't have timeouts and retries. It will be used to transport workflow updates to the worker.
How did you test it?
Manually for now. Automated tests will be added with workflow update feature.
Potential risks
No risks.
Is hotfix candidate?
No.