Enable durable archival #3828
Merged
Enable durable archival #3828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yux0
reviewed
Jan 24, 2023
| @@ -410,7 +410,7 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int32, isAdvancedVis | |||
| NumArchiveSystemWorkflows: dc.GetIntProperty(dynamicconfig.NumArchiveSystemWorkflows, 1000), | |||
| ArchiveRequestRPS: dc.GetIntProperty(dynamicconfig.ArchiveRequestRPS, 300), // should be much smaller than frontend RPS | |||
| ArchiveSignalTimeout: dc.GetDurationProperty(dynamicconfig.ArchiveSignalTimeout, 300*time.Millisecond), | |||
| DurableArchivalEnabled: dc.GetBoolProperty(dynamicconfig.DurableArchivalEnabled, false), | |||
| DurableArchivalEnabled: dc.GetBoolProperty(dynamicconfig.DurableArchivalEnabled, true), | |||
There was a problem hiding this comment.
do we want to enable it by default?
There was a problem hiding this comment.
Yes; this won't do anything for people not using archival, but it will migrate users who are to the new system. We'll need to include a notice in the patch notes
yux0
approved these changes
Jan 24, 2023
MichaelSnowden
force-pushed
the
snowden/enable-archival-base
branch
from
299be8f
to
285bf33
Compare
MichaelSnowden
force-pushed
the
snowden/enable-durable-archival
branch
from
8c4cfca
to
c6d1d60
Compare
MichaelSnowden
changed the base branch from
snowden/enable-archival-base
to
master
MichaelSnowden
added a commit
that referenced
this pull request
Jan 31, 2023
MichaelSnowden
added a commit
that referenced
this pull request
Feb 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
This PR enables the archival queue by default.
Why?
To finish the migration to the new archival system.
How did you test it?
I ran manual tests to:
Potential risks
There are very few users currently using archival, but durable archival is designed to be forwards and backwards-compatible, so migrating existing users should not create any issues. However, the archival queue hasn't been tested on a large scale yet.
Is hotfix candidate?
Yes