Add index name to constructor of search attribute validator #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelSnowden
approved these changes
Jan 26, 2023
rodrigozhou
force-pushed
the
sa-validator-ctor-index-name
branch
from
b8b9680
to
8466801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added index name to constructor of search attributes validator.
Why?
Validator functions already require index name which should be constant throughout the execution of the Server, so moving the constructor. It will avoid needing to keep track of index name and validator objects separately in the codebase in case the validator object is passed to other structs.
How did you test it?
Existing tests.
Potential risks
There shouldn't have any risks.
Is hotfix candidate?
No.