Move namespace handler to service/frontend #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
reviewed
Jan 26, 2023
| if s.State == enumspb.ARCHIVAL_STATE_ENABLED && len(s.URI) == 0 { | ||
| return errInvalidState | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| func (s *ArchivalState) getNextState( | ||
| e *ArchivalEvent, | ||
| func (s *ArchivalConfigState) GetNextState( |
alexshtin
approved these changes
Jan 27, 2023
alexshtin
reviewed
Jan 27, 2023
rodrigozhou
force-pushed
the
move-namespace-handler
branch
from
1a3dbcf
to
9dbc89a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Moved
namespace/handler.gotoservice/frontend/namespace_handler.go.Renamed
namespace.ArchivalStatetonamespace.ArchivalConfigState.Renamed
namespace.ArchivalEventtonamespace.ArchivalConfigEvent.Why?
namespacemodule is depending onarchivermodule, which will cause potential circular dependencies (eg:searchattributemodule cannot importnamespace).Since the namespace handler is only used by
frontend, I'm moving it there.As for the renaming, there's another type name
ArchivalStatealready defined inarchiver, so I'm changing the one in namespace to better distinguish them.How did you test it?
Existing tests.
Potential risks
No.
Is hotfix candidate?
No.