Implement default mapper for SQL visibility #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigozhou
force-pushed
the
sa-ns-mapper
branch
from
d468582
to
7554465
Compare
rodrigozhou
force-pushed
the
sa-ns-mapper
branch
from
7554465
to
61a8fef
Compare
alexshtin
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updated
searchattribute.MapperProviderto support the mapper from namespace config.Created wrapper mapper to be backwards compatible with custom search attributes registered while using SQL DB.
Added integration tests using mysql8 and postgres12 plugins.
Why?
This is the default mapper when using SQL DB for advanced visibility.
How did you test it?
Existing unit tests. Needs more tests to cover new case, but postponing to another PR.
Potential risks
No.
Is hotfix candidate?
No.