Protect UpdateWorkflowExecution API with dynamic config feature flag #3884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiminc
approved these changes
Feb 2, 2023
| @@ -250,6 +250,9 @@ const ( | |||
| // FrontendEnableBatcher enables batcher-related RPCs in the frontend | |||
| FrontendEnableBatcher = "frontend.enableBatcher" | |||
|
|
|||
| // FrontendEnableUpdateWorkflowExecution enables UpdateWorkflowExecution API in the frontend. | |||
| FrontendEnableUpdateWorkflowExecution = "frontend.enableUpdateWorkflowExecution" | |||
There was a problem hiding this comment.
Add comment that this feature is in development and is not ready to use in prod.
alexshtin
force-pushed
the
feature/update-workflow-feature-flag
branch
from
2b0c009
to
784dfa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Protect
UpdateWorkflowExecutionAPI with dynamic config feature flag.falseby default.Why?
UpdateWorkflowExecutionAPI has some known bugs and generally is in alpha stage. Only opt-in namespaces should be able to use (try, really) it.How did you test it?
Functional tests are failing when no override is set.
Potential risks
No risks.
Is hotfix candidate?
No.