Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker config template to set only one visibility #3889

Merged

Conversation

rodrigozhou
Copy link
Collaborator

@rodrigozhou rodrigozhou commented Feb 2, 2023

What changed?
Fix docker config template to set up only one visibility store.

Why?
Having both standard and advanced visibility store configs make the Server to set up dual visibility store, which messes up with search attributes.

How did you test it?
Build docker images, ran it, and checked logs.

Potential risks
No.

Is hotfix candidate?
No.

@rodrigozhou rodrigozhou requested a review from a team as a code owner February 2, 2023 18:15
Copy link
Contributor

@mindaugasrukas mindaugasrukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodrigozhou rodrigozhou merged commit 19d36fb into temporalio:master Feb 2, 2023
@rodrigozhou rodrigozhou deleted the fix-docker-config-template branch February 2, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants