Pass workflowTask object to completion methods of mutable state #3897
Conversation
| @@ -482,23 +482,10 @@ func (m *workflowTaskStateMachine) skipWorkflowTaskCompletedEvent(workflowTaskTy | |||
| return onlyUpdateRejectionMessages | |||
| } | |||
| func (m *workflowTaskStateMachine) AddWorkflowTaskCompletedEvent( | |||
| scheduledEventID int64, | |||
| startedEventID int64, | |||
| workflowTask *WorkflowTaskInfo, | |||
There was a problem hiding this comment.
This file is an actual change. All the rest is just update callers and tests.
Everywhere where these 3 methods are called workflow task object already exist and populated with correct data. I am now passing it directly instead of calling m.GetWorkflowTaskInfo(scheduledEventID) one more time.
| ) { | ||
| // TODO (alex-update): Uncomment this code to support speculative workflow task restoration. | ||
|
|
||
| /* | ||
| // StartedEventID might be lost (cleared) for speculative workflow task due to shard reload or history service restart. | ||
| if workflowTask != nil && workflowTask.Type == enumsspb.WORKFLOW_TASK_TYPE_SPECULATIVE && workflowTask.StartedEventID == common.EmptyEventID { | ||
| workflowTask.StartedEventID = startedEventID | ||
| workflowTask.StartedEventID = workflowTask.ScheduledEventID + 1 |
There was a problem hiding this comment.
Started ID is always scheduled ID + 1? I don't recall we buffer events when there's a scheduled workflow task, or is speculative workflow task different?
There was a problem hiding this comment.
For normal WT we don't buffer events after scheduled WT, we only buffer them after WT is started. This formula won't work for it. Speculative (and transient) WT gets converted to normal when started, if there are new events came after it was scheduled.
What changed?
Pass
workflowTaskobject to completion methods of mutable state.Why?
To avoid reconstruction of
workflowTaskobject from mutable state every time.How did you test it?
Existing tests.
Potential risks
No risks.
Is hotfix candidate?
No.