Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn ErrWorkflowClosing into a retryable error #4765

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

yycptt
Copy link
Member

@yycptt yycptt commented Aug 10, 2023

What changed?

  • Turn ErrWorkflowClosing into a retryable error: resource exhausted with workflow busy cause.
  • The error means workflow is about to close so the operation can not be applied at this time. But the operation will be able to be applied if workflow continues as new or get rejected if workflow completes. and by retrying, hopefully customer won't see the error (depending how fast they process their workflow task).

Why?

  • so that user doesn't have to retry on their end in most cases.
  • resource exhausted error also won't be retried by service handler.

How did you test it?

  • Existing functional test

Potential risks

Is hotfix candidate?

@yycptt yycptt requested a review from yiminc August 10, 2023 23:40
@yycptt yycptt requested a review from a team as a code owner August 10, 2023 23:40
@yycptt yycptt enabled auto-merge (squash) August 10, 2023 23:54
@yycptt yycptt merged commit e4ce970 into temporalio:main Aug 11, 2023
8 checks passed
@yycptt yycptt deleted the fix-workflow-closing-err branch August 11, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants