Add more logging message to monitor branch token update #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
approved these changes
Oct 31, 2023
| @@ -121,6 +127,10 @@ func GetOrPollMutableState( | |||
| return nil, err | |||
| } | |||
| if !versionhistory.ContainsVersionHistoryItem(currentVersionHistory, request.VersionHistoryItem) { | |||
| logger.Warn("Request history branch and current history branch are mismatched prior to poll the mutable state.", | |||
There was a problem hiding this comment.
Suggested change
| logger.Warn("Request history branch and current history branch are mismatched prior to poll the mutable state.", | |
| logger.Warn("Request history branch and current history branch don't match prior to polling the mutable state", |
| @@ -94,6 +96,10 @@ func GetOrPollMutableState( | |||
| // We return the full version histories. Callers need to fetch the last version history item from current branch | |||
| // and use the last version history item in following calls. | |||
| if !versionhistory.ContainsVersionHistoryItem(currentVersionHistory, request.VersionHistoryItem) { | |||
| logger.Warn("Request history branch and current history branch are mismatched.", | |||
| tag.Value(currentVersionHistory), | |||
There was a problem hiding this comment.
I don't know much about this yet; is currentVersionHistory safe to log? Safe in terms of (a) security, (b) size and (c) performance?
There was a problem hiding this comment.
change to log the last item. The length is fixed.
Co-authored-by: Stephan Behnke <stephanos@users.noreply.github.com>
Co-authored-by: Stephan Behnke <stephanos@users.noreply.github.com>
stephanos
approved these changes
Oct 31, 2023
Co-authored-by: Stephan Behnke <stephanos@users.noreply.github.com>
yux0
added a commit
that referenced
this pull request
Nov 21, 2023
<!-- Describe what has changed in this PR --> **What changed?** Add more logging message to monitor branch token update <!-- Tell your future self why have you made these changes --> **Why?** better debugging. <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> **How did you test it?** only logging. <!-- Assuming the worst case, what can be broken when deploying this change to production? --> **Potential risks** <!-- Is this PR a hotfix candidate or require that a notification be sent to the broader community? (Yes/No) --> **Is hotfix candidate?** --------- Co-authored-by: Stephan Behnke <stephanos@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Add more logging message to monitor branch token update
Why?
better debugging.
How did you test it?
only logging.
Potential risks
Is hotfix candidate?