Improve error type extraction for logs #5400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Port the type unwrapping code from our metrics to our util package and use it 2. Rename tag.ErrorType to tag.ServiceErrorType and create a new tag.ErrorType 3. Report the type for all task errors we log
stephanos
approved these changes
Feb 14, 2024
| @@ -61,7 +62,7 @@ func errorType(err error) string { | |||
| q = q[:len(q)-1] | |||
| errType := fmt.Sprintf("%T", err) | |||
| if !wrapperErrorTypes[errType] { | |||
| return errType | |||
| return strings.TrimPrefix(errType, "*") | |||
There was a problem hiding this comment.
I see that this code existed already, but it's not clear to me why an error would start with one or multiple *? If this is sth we introduced, could this be a constant in a single place?
There was a problem hiding this comment.
*fmt.wrapError is the type of an error. So is *serviceerror.Foo.
We don't care that they're pointers, so we remove the prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
So that we know what type of unexpected errors we're encountering during task processing
How did you test it?
Potential risks
Is hotfix candidate?