Update api-go and sdk-go to allow invalid UTF-8 in protos #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdeebswihart
force-pushed
the
tds/invalid-utf8-in-protos
branch
2 times, most recently
from
35fb960 to
17140dd
Compare
tdeebswihart
commented
Mar 1, 2024
dnr
reviewed
Mar 1, 2024
tdeebswihart
force-pushed
the
tds/invalid-utf8-in-protos
branch
from
17140dd to
833c784
Compare
tdeebswihart
force-pushed
the
tds/invalid-utf8-in-protos
branch
from
e45ce6b to
3332965
Compare
tdeebswihart
added a commit
to temporalio/sdk-go
that referenced
this pull request
Mar 1, 2024
…1408) ## What was changed This PR adds an integration test to validate that we allow invalid UTF-8 data in strings. ## Testing You will need to run the server locally as of temporalio/temporal#5476, then execute the integration tests. This test has been manually verified as passing on SDK version 1.25.0 and server version 1.22.5, so we should remain compatible with our pre-google/protobuf behavior
tdeebswihart
force-pushed
the
tds/invalid-utf8-in-protos
branch
from
3332965 to
5229241
Compare
The version of gogo/protobuf we used allowed invalid UTF-8 in strings which is a violation of the proto3 spec. We were unaware of this until our new google/protobuf based structs began failing to deserialize data we'd used previously
Co-authored-by: David Reiss <david@temporal.io>
tdeebswihart
force-pushed
the
tds/invalid-utf8-in-protos
branch
from
ba2768a to
eb63688
Compare
tdeebswihart
added a commit
that referenced
this pull request
Mar 1, 2024
I've upgraded the version of our Go API in order to allow invalid UTF-8 data in our proto strings. Please review 5cf9790 only The version of gogo/protobuf we used allowed invalid UTF-8 in strings which is a violation of the proto3 spec. We were unaware of this until our new google/protobuf based structs began failing to deserialize data we'd used previously I added a new end-to-end test to verify that we can create, describe, and delete a namespace that contains invalid UTF-8 in multiple attributes This is lower risk than commits prior to this as temporal DBs may already contain invalid UTF-8 data I adjusted our docs to mention this behavior and the `protolegacy` tag Yes: this will be going out as part of our 1.23.0 release. In fact, the release is blocked on it! --------- Co-authored-by: David Reiss <david@temporal.io>
stephanos
pushed a commit
to stephanos/temporal
that referenced
this pull request
Mar 21, 2024
…#5476) I've upgraded the version of our Go API in order to allow invalid UTF-8 data in our proto strings. Please review temporalio@5cf9790 only The version of gogo/protobuf we used allowed invalid UTF-8 in strings which is a violation of the proto3 spec. We were unaware of this until our new google/protobuf based structs began failing to deserialize data we'd used previously I added a new end-to-end test to verify that we can create, describe, and delete a namespace that contains invalid UTF-8 in multiple attributes This is lower risk than commits prior to this as temporal DBs may already contain invalid UTF-8 data I adjusted our docs to mention this behavior and the `protolegacy` tag Yes: this will be going out as part of our 1.23.0 release. In fact, the release is blocked on it! --------- Co-authored-by: David Reiss <david@temporal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
I've upgraded the version of our Go API in order to allow invalid UTF-8 data in our proto strings.
Please review 5cf9790 only
Why?
The version of gogo/protobuf we used allowed invalid UTF-8 in strings which is a violation of the proto3 spec. We were unaware of this until our new google/protobuf based structs began failing to deserialize data we'd used previously
How did you test it?
I added a new end-to-end test to verify that we can create, describe, and delete a namespace that contains invalid UTF-8 in multiple attributes
Potential risks
This is lower risk than commits prior to this as temporal DBs may already contain invalid UTF-8 data
Documentation
Is hotfix candidate?
Yes: this will be going out as part of our 1.23.0 release. In fact, the release is blocked on it!