-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExecuteMultiOperation API #5577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
changed the title
Add MultiOperationService
Add MultiOperationService skeleton
Mar 22, 2024
stephanos
changed the title
Add MultiOperationService skeleton
Add MultiOperation API skeleton
Mar 22, 2024
stephanos
changed the title
Add MultiOperation API skeleton
Add ExecuteMultiOperation skeleton
Mar 22, 2024
stephanos
changed the title
Add ExecuteMultiOperation skeleton
Add ExecuteMultiOperation API
Mar 22, 2024
stephanos
force-pushed
the
multiops-api
branch
5 times, most recently
from
March 22, 2024 19:10
541cb94
to
1ed1e04
Compare
stephanos
force-pushed
the
multiops-api
branch
2 times, most recently
from
March 22, 2024 19:42
be2a2df
to
5fca200
Compare
stephanos
commented
Mar 22, 2024
stephanos
commented
Mar 22, 2024
stephanos
force-pushed
the
multiops-api
branch
3 times, most recently
from
April 4, 2024 15:53
479a2fe
to
5820ad6
Compare
stephanos
commented
Apr 4, 2024
stephanos
commented
Apr 4, 2024
alexshtin
reviewed
Apr 4, 2024
proto/internal/temporal/server/api/historyservice/v1/request_response.proto
Outdated
Show resolved
Hide resolved
alexshtin
reviewed
Apr 5, 2024
alexshtin
reviewed
Apr 5, 2024
stephanos
force-pushed
the
multiops-api
branch
2 times, most recently
from
April 5, 2024 19:38
ca608ba
to
65d327f
Compare
alexshtin
approved these changes
Apr 5, 2024
stephanos
force-pushed
the
multiops-api
branch
2 times, most recently
from
April 13, 2024 02:23
5cdaf19
to
d315a90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Happy-path implementation for temporalio/api#367
This is just the first version; it'll need more work (e.g. more validation and tests) before it can be production-ready.
It is behind a feature flag.
Why?
Putting up the review now so the API change can be merged; and no feature branch is necessary anymore.
How did you test it?
Net new API behind feature flag, needs more testing.
Potential risks
It's behind a feature flag.
Documentation
Is hotfix candidate?