Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExecuteMultiOperation API #5577

Merged
merged 27 commits into from
Apr 13, 2024
Merged

Conversation

stephanos
Copy link
Contributor

@stephanos stephanos commented Mar 22, 2024

What changed?

Happy-path implementation for temporalio/api#367

This is just the first version; it'll need more work (e.g. more validation and tests) before it can be production-ready.

It is behind a feature flag.

Why?

Putting up the review now so the API change can be merged; and no feature branch is necessary anymore.

How did you test it?

Net new API behind feature flag, needs more testing.

Potential risks

It's behind a feature flag.

Documentation

Is hotfix candidate?

@stephanos stephanos changed the title Add MultiOperationService Add MultiOperationService skeleton Mar 22, 2024
@stephanos stephanos changed the title Add MultiOperationService skeleton Add MultiOperation API skeleton Mar 22, 2024
@stephanos stephanos changed the title Add MultiOperation API skeleton Add ExecuteMultiOperation skeleton Mar 22, 2024
@stephanos stephanos changed the title Add ExecuteMultiOperation skeleton Add ExecuteMultiOperation API Mar 22, 2024
@stephanos stephanos force-pushed the multiops-api branch 5 times, most recently from 541cb94 to 1ed1e04 Compare March 22, 2024 19:10
@stephanos stephanos force-pushed the multiops-api branch 2 times, most recently from be2a2df to 5fca200 Compare March 22, 2024 19:42
@stephanos stephanos marked this pull request as ready for review March 22, 2024 23:13
@stephanos stephanos requested a review from a team as a code owner March 22, 2024 23:13
@stephanos stephanos marked this pull request as draft March 25, 2024 18:30
@stephanos stephanos force-pushed the multiops-api branch 3 times, most recently from 479a2fe to 5820ad6 Compare April 4, 2024 15:53
tests/workflow.go Outdated Show resolved Hide resolved
tests/workflow.go Outdated Show resolved Hide resolved
service/history/api/multioperation/api.go Outdated Show resolved Hide resolved
service/history/api/multioperation/api.go Outdated Show resolved Hide resolved
service/history/api/multioperation/api.go Outdated Show resolved Hide resolved
service/history/api/updateworkflow/api.go Outdated Show resolved Hide resolved
service/history/api/updateworkflow/api.go Show resolved Hide resolved
service/history/workflow/context.go Show resolved Hide resolved
tests/workflow.go Outdated Show resolved Hide resolved
@stephanos stephanos force-pushed the multiops-api branch 2 times, most recently from ca608ba to 65d327f Compare April 5, 2024 19:38
@stephanos stephanos marked this pull request as ready for review April 5, 2024 21:35
@stephanos stephanos force-pushed the multiops-api branch 2 times, most recently from 5cdaf19 to d315a90 Compare April 13, 2024 02:23
@stephanos stephanos enabled auto-merge (squash) April 13, 2024 02:38
@stephanos stephanos merged commit f34f22c into temporalio:main Apr 13, 2024
39 of 42 checks passed
@stephanos stephanos deleted the multiops-api branch April 13, 2024 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants