ShutdownWorker frontend implementation #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlydf
reviewed
Sep 13, 2024
| return nil, err | ||
| } | ||
|
|
||
| // TODO: update poller info to indicate poller was shut down (pass identity/reason along) |
There was a problem hiding this comment.
did you still want to do this TODO?
There was a problem hiding this comment.
Yeah, for now we're just using ForceUnloadTaskQueue as-is, so it doesn't note these.
Shivs11
requested changes
Sep 13, 2024
This was referenced Sep 24, 2024
bergundy
approved these changes
Sep 27, 2024
Shivs11
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
ForceUnloadTaskQueuein Matching.Why?
How did you test it?
Potential risks
ForceUnloadTaskQueue. If callers were to abuse the operation, they could force history being reloaded as the sticky queue is cleared.Documentation
Is hotfix candidate?