Fix legacy DescribeTaskQueue for non-root partitions #6596
Merged
+71
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rodrigozhou |
# Conflicts: # tests/describe_task_queue.go
dnr
approved these changes
Oct 9, 2024
| @@ -67,14 +102,14 @@ func NormalizeAndValidate( | |||
| taskQueue.Name = defaultName | |||
| } | |||
|
|
|||
| if err := Validate(taskQueue.GetName(), maxIDLengthLimit); err != nil { | |||
| if err := validate(taskQueue.GetName(), maxIDLengthLimit, expectNonRootPartition); err != nil { | |||
| return err | |||
| } | |||
|
|
|||
| if taskQueue.GetKind() == enumspb.TASK_QUEUE_KIND_STICKY { | |||
| normalName := taskQueue.GetNormalName() | |||
| if normalName != "" { | |||
There was a problem hiding this comment.
Not changing in this PR, but this might deserve a comment that old SDKs send sticky without a normal name, so we don't require that it be set here.
common/tqid/task_queue_validator.go
Outdated
| taskQueue *taskqueue.TaskQueue, | ||
| defaultName string, | ||
| maxIDLengthLimit int, | ||
| expectNonRootPartition bool, |
There was a problem hiding this comment.
expectNonRootPartition feels slightly misleading since it's not "expect non-root", it's "expect root or non-root". So maybe invert it and call it expectRoot?
dnr
reviewed
Oct 14, 2024
| @@ -247,6 +247,7 @@ func (handler *WorkflowTaskCompletedHandler) Invoke( | |||
| } | |||
| }() | |||
|
|
|||
| // TODO: this check is only | |||
There was a problem hiding this comment.
oops this sneaked in from an unrelated work. removed the line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
DescribeTaskQueue has to support non-root partitions for legacy mode to keep supporting
tctlandtemporalCLIs.This PR is fixing a regression caused by https://github.com/temporalio/temporal/pull/6419/files
Why?
The mentioned PR is validating DescribeTaskQueue input similar to other APIs and rejects when task queue name is a non-root partition (starts with
/_sys/prefix). This is not correct, DescribeTaskQueue is different from other API and it has to keep accepting names with this prefix to remain compatible with supported CLIs.How did you test it?
Added functioonal and unit tests.
Potential risks
Documentation
Is hotfix candidate?
Yes