Update-with-Start with policy Terminate-Existing #6783
+28
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanos
force-pushed
the
uws-terminate
branch
8 times, most recently
from
ab543ec
to
35bfb55
Compare
stephanos
force-pushed
the
uws-terminate
branch
2 times, most recently
from
839e764
to
e19785a
Compare
stephanos
added a commit
that referenced
this pull request
Nov 16, 2024
## What changed? <!-- Describe what has changed in this PR --> Introducing a new StartOutcome type. It signals the kind of start that was performed. I considered various other options (like sentinel error types and adding a new field to the proto), but then decided on this. ## Why? <!-- Tell your future self why have you made these changes --> This is needed for making Terminate-Existing work, since there it's important to distinguish between "deduped" and "reused". See #6783 ## How did you test it? <!-- How have you verified this change? Tested locally? Added a unit test? Checked in staging env? --> ## Potential risks <!-- Assuming the worst case, what can be broken when deploying this change to production? --> ## Documentation <!-- Have you made sure this change doesn't falsify anything currently stated in `docs/`? If significant new behavior is added, have you described that in `docs/`? --> ## Is hotfix candidate? <!-- Is this PR a hotfix candidate or does it require a notification to be sent to the broader community? (Yes/No) -->
stephanos
force-pushed
the
uws-terminate
branch
from
e19785a
to
4e8f01b
Compare
alexshtin
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Depends on #6795
What changed?
Support for Terminate-Existing workflow conflict policy in Update-with-Start.
Why?
Complete UwS' conflict policy support.
How did you test it?
Re-enabled Terminate-Existing functional tests.
Potential risks
Documentation
Is hotfix candidate?