Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Embed UI server #29

Merged
merged 1 commit into from
Dec 30, 2021
Merged

Embed UI server #29

merged 1 commit into from
Dec 30, 2021

Conversation

jlegrone
Copy link
Collaborator

@jlegrone jlegrone commented Dec 18, 2021

What changed?

Embeds the new Temporal UI server and static assets.

Why?

Closes #22

How did you test it?

go run ./cmd/temporalite start

Potential risks

  • Binary size went from 76.6 to 99.4 MB. We might want to conditionally compile static assets into the binary in the future.
  • There's a higher chance of port conflicts on 8080, which seems to be pretty commonly used in other areas of the Temporal ecosystem. In order to mitigate this, Temporalite defaults the web UI port to the frontend-service port + 1000.
  • Importing temporal server and ui server packages in the same module also emits duplicate protobuf registration error logs. This could introduce issues if the protos drift between upstream modules, but I think it should be safe enough to merge this for now and fix the conflicts upstream.

Is hotfix candidate?

No

go.mod Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2021

Codecov Report

Merging #29 (0bd2218) into main (5d2482f) will decrease coverage by 1.16%.
The diff coverage is 18.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
- Coverage   45.39%   44.23%   -1.17%     
==========================================
  Files          11       11              
  Lines         652      685      +33     
==========================================
+ Hits          296      303       +7     
- Misses        337      362      +25     
- Partials       19       20       +1     
Impacted Files Coverage Δ
cmd/temporalite/main.go 1.58% <0.00%> (-0.30%) ⬇️
options.go 51.16% <0.00%> (-5.25%) ⬇️
server.go 62.82% <60.00%> (-0.20%) ⬇️
internal/liteconfig/config.go 87.41% <100.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2482f...0bd2218. Read the comment docs.

@jlegrone jlegrone force-pushed the jlegrone/embed-ui branch 2 times, most recently from c712dcd to a5301c7 Compare December 18, 2021 05:12
cmd/temporalite/main.go Outdated Show resolved Hide resolved
@swyxio
Copy link

swyxio commented Dec 25, 2021

both have been merged!

@jlegrone jlegrone enabled auto-merge (squash) December 30, 2021 17:29
@jlegrone jlegrone merged commit 583fa90 into main Dec 30, 2021
@jlegrone jlegrone deleted the jlegrone/embed-ui branch December 30, 2021 22:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed Temporal web UI
3 participants