Skip to content
This repository has been archived by the owner on Apr 3, 2024. It is now read-only.

Update github.com/temporalio/ui-server #40

Merged
merged 1 commit into from
Feb 26, 2022
Merged

Conversation

jlegrone
Copy link
Collaborator

@jlegrone jlegrone commented Feb 7, 2022

What changed?

Updates ui-server to the latest tagged release commit. Dependabot should be able to start tracking new versions going forward.

Update: We're still unable to use a tagged release until a new version is cut now that temporalio/ui#267 is merged.

Why?

How did you test it?

Potential risks

Is hotfix candidate?

@jlegrone jlegrone marked this pull request as draft February 7, 2022 21:59
@jlegrone
Copy link
Collaborator Author

jlegrone commented Feb 7, 2022

Setting this PR to draft for now; loading the UI at this version results in the error invalid query: unable to convert filter expression: unable to convert values of comparison expression: StartTime only supports BETWEEN ... AND ... filter

go.temporal.io/server/common/log.(*zapLogger).Error
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/log/zap_logger.go:142
go.temporal.io/server/common/persistence/visibility.(*visibilityManagerMetrics).updateErrorMetric
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/persistence/visibility/visiblity_manager_metrics.go:196
go.temporal.io/server/common/persistence/visibility.(*visibilityManagerMetrics).ListWorkflowExecutions
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/persistence/visibility/visiblity_manager_metrics.go:149
go.temporal.io/server/service/frontend.(*WorkflowHandler).ListWorkflowExecutions
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/service/frontend/workflowHandler.go:2267
go.temporal.io/server/service/frontend.(*DCRedirectionHandlerImpl).ListWorkflowExecutions.func2
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/service/frontend/dcRedirectionHandler.go:405
go.temporal.io/server/service/frontend.(*NoopRedirectionPolicy).WithNamespaceRedirect
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/service/frontend/dcRedirectionPolicy.go:118
go.temporal.io/server/service/frontend.(*DCRedirectionHandlerImpl).ListWorkflowExecutions
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/service/frontend/dcRedirectionHandler.go:401
go.temporal.io/api/workflowservice/v1._WorkflowService_ListWorkflowExecutions_Handler.func1
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/api@v1.7.0/workflowservice/v1/service.pb.go:1482
go.temporal.io/server/common/authorization.(*interceptor).Interceptor
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/authorization/interceptor.go:152
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1116
go.temporal.io/server/common/rpc/interceptor.(*NamespaceCountLimitInterceptor).Intercept
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/rpc/interceptor/namespace_count_limit.go:98
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
go.temporal.io/server/common/rpc/interceptor.(*NamespaceRateLimitInterceptor).Intercept
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/rpc/interceptor/namespace_rate_limit.go:88
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
go.temporal.io/server/common/rpc/interceptor.(*RateLimitInterceptor).Intercept
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/rpc/interceptor/rate_limit.go:83
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
go.temporal.io/server/common/rpc/interceptor.(*NamespaceValidatorInterceptor).Intercept
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/rpc/interceptor/namespace_validator.go:113
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
go.temporal.io/server/common/rpc/interceptor.(*TelemetryInterceptor).Intercept
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/rpc/interceptor/telemetry.go:108
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
go.temporal.io/server/common/metrics.NewServerMetricsContextInjectorInterceptor.func1
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/metrics/grpc.go:66
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
go.temporal.io/server/common/rpc.ServiceErrorInterceptor
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/rpc/grpc.go:131
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
go.temporal.io/server/common/rpc/interceptor.(*NamespaceLogInterceptor).Intercept
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/server@v1.14.4/common/rpc/interceptor/namespace_logger.go:84
google.golang.org/grpc.chainUnaryInterceptors.func1.1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1119
google.golang.org/grpc.chainUnaryInterceptors.func1
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1121
go.temporal.io/api/workflowservice/v1._WorkflowService_ListWorkflowExecutions_Handler
    /Users/jacob.legrone/go/pkg/mod/go.temporal.io/api@v1.7.0/workflowservice/v1/service.pb.go:1484
google.golang.org/grpc.(*Server).processUnaryRPC
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1282
google.golang.org/grpc.(*Server).handleStream
    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:1616
google.golang.org/grpc.(*Server).serveStreams.func1.2    /Users/jacob.legrone/go/pkg/mod/google.golang.org/grpc@v1.42.0/server.go:921

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2022

Codecov Report

Merging #40 (0d5bbda) into main (86a3b8e) will decrease coverage by 0.34%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   41.93%   41.58%   -0.35%     
==========================================
  Files          11       11              
  Lines         725      731       +6     
==========================================
  Hits          304      304              
- Misses        399      405       +6     
  Partials       22       22              
Impacted Files Coverage Δ
cmd/temporalite/main.go 1.31% <0.00%> (-0.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86a3b8e...0d5bbda. Read the comment docs.

@nadilas
Copy link

nadilas commented Feb 21, 2022

I checked again after the latest bump of temporal server to 1.15.0

The same config server 1.15.0 and ui-server 0.2.0 works in https://github.com/temporalio/docker-compose/blob/fa3a53ece0473514a9a8ee2915f750c48eaf6831/docker-compose-ui-experimental.yml#L42

The embedded ui-server 0.2.0 doesn't throw errors on the backend, but the same error bubbles up to the new ui.

The ui 0.2.0 uses an older api v1.5.0

@jlegrone
Copy link
Collaborator Author

Blocking on temporalio/ui#249

@jlegrone
Copy link
Collaborator Author

jlegrone commented Feb 25, 2022

Now blocking on temporalio/ui-server#106 and a new tagged release of ui-server.

Edit: I was able to work around the remaining issues, so we can just manually update when the next tagged release is available.

@jlegrone jlegrone changed the title Update github.com/temporalio/ui-server to v0.2.0 Update github.com/temporalio/ui-server Feb 25, 2022
@jlegrone jlegrone marked this pull request as ready for review February 25, 2022 22:01
@jlegrone jlegrone enabled auto-merge (squash) February 25, 2022 22:02
@jlegrone jlegrone deleted the jlegrone/update-ui branch February 26, 2022 04:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants