This repository has been archived by the owner on Apr 3, 2024. It is now read-only.
Disable web UI via build tag or runtime flag #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #47 +/- ##
==========================================
- Coverage 41.93% 41.70% -0.24%
==========================================
Files 11 12 +1
Lines 725 729 +4
==========================================
Hits 304 304
- Misses 399 403 +4
Partials 22 22
Continue to review full report at Codecov.
|
jlegrone
force-pushed
the
jlegrone/skip-ui
branch
5 times, most recently
from
6bd6654
to
57f04fb
Compare
jlegrone
changed the title
jlegrone
changed the title
jlegrone
force-pushed
the
jlegrone/skip-ui
branch
from
57f04fb
to
d2de294
Compare
jlegrone
force-pushed
the
jlegrone/skip-ui
branch
from
d2de294
to
75ee704
Compare
lminaudier
approved these changes
Feb 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Closes #33
Why?
Temporalite isn't always used in environments where a web UI is required or desired. Adding a build tag to disable the web UI is also a mitigation for #46.
How did you test it?
Added a unit test to ensure that the ui-server package is not part of the dependency graph when the
headlessbuild tag is specified, and also added this build tag to the test matrix in CI.Potential risks
Is hotfix candidate?
No