Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross chain testing scripts. #2033

Merged
merged 22 commits into from
Sep 3, 2024
Merged

Conversation

StefanIliev545
Copy link
Contributor

@StefanIliev545 StefanIliev545 commented Aug 21, 2024

Why this change is needed

This PR adds a couple of hardhat scripts that can be used to test some more specific cases which are harder to perform in go in order to enable easier debugging. It also presets some network configs for easier debugging.

Furthermore it contains a fix for bundles that are built for rollups without any cannonical batches where the state machine gets stuck as we cannot progress on this type of error.

What changes were made as part of this PR

Please provide a high level list of the changes made

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor comments/questions

contracts/config/networks.json Show resolved Hide resolved
go/host/l1/statemachine.go Outdated Show resolved Hide resolved
go/host/rpc/clientapi/client_api_eth.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@BedrockSquirrel BedrockSquirrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StefanIliev545 StefanIliev545 merged commit 56fee0e into main Sep 3, 2024
3 checks passed
@StefanIliev545 StefanIliev545 deleted the siliev/bundles-investigation branch September 3, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants