Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP investigate gw bug #2130

Merged
merged 5 commits into from
Nov 8, 2024
Merged

WIP investigate gw bug #2130

merged 5 commits into from
Nov 8, 2024

Conversation

tudor-malene
Copy link
Collaborator

@tudor-malene tudor-malene commented Nov 7, 2024

Why this change is needed

to fix an issue when running the e2e tests

What changes were made as part of this PR

  • some cleanup
  • change the sqlite configuration to behave predictably

PR checks pre-merging

Please indicate below by ticking the checkbox that you have read and performed the required
PR checks

  • PR checks reviewed and performed

Copy link
Contributor

@zkokelj zkokelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

LGTM 👍

@moraygrieve moraygrieve merged commit 7547940 into main Nov 8, 2024
2 checks passed
@moraygrieve moraygrieve deleted the tudor/fix_estimate_gas_from branch November 8, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants