Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added feature for Widgets API under Tenable.ad #466

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

dheerajrp
Copy link
Contributor

@dheerajrp dheerajrp commented Nov 17, 2021

Description

  1. Added new feature for Widgets API under tenable.ad.
  2. Added test case for APIs and the schema.
  3. Added docstrings to methods to support documentation

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Pytest
  • Sphinx build for the documentation

Test Configuration:

  • Python Version(s) Tested:
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@SteveMcGrath SteveMcGrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes related to testing output, flake8, and general style.

Please make the requested changes, then squash your commits and and force-push.

docs/api/index.rst Outdated Show resolved Hide resolved
tenable/ad/widget/api.py Show resolved Hide resolved
tenable/ad/widget/api.py Show resolved Hide resolved
tenable/ad/widget/api.py Show resolved Hide resolved
tenable/ad/widget/api.py Show resolved Hide resolved
tenable/ad/widget/api.py Outdated Show resolved Hide resolved
tenable/ad/widget/api.py Outdated Show resolved Hide resolved
tenable/ad/widget/api.py Outdated Show resolved Hide resolved
tenable/ad/widget/api.py Outdated Show resolved Hide resolved
tenable/ad/widget/api.py Outdated Show resolved Hide resolved
deleting unnecessary files

support for Widgets API

added support for t.ad widgets API, added the test cases and docstrings.

added rst  file to docs

added feature for directories API and addressed review comments

updated docstrings and few changes in doc build
@dheerajrp dheerajrp force-pushed the feature/tenable.ad-widgets branch from a2dbe95 to 7f2cac9 Compare November 22, 2021 13:02
@dheerajrp dheerajrp marked this pull request as ready for review November 29, 2021 18:17
@dheerajrp dheerajrp requested a review from a team November 29, 2021 18:17
tenable/ad/api_keys.py Outdated Show resolved Hide resolved
@SteveMcGrath SteveMcGrath merged commit 7accee2 into master Dec 1, 2021
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad-widgets branch December 1, 2021 16:53
@SteveMcGrath SteveMcGrath added this to the 1.5 milestone Dec 10, 2021
@SteveMcGrath SteveMcGrath added enhancement New features/functionality unit-testing This issue requires new/updated tests documentation Documentation issues Tenable.ad Tenable.ad Package labels Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues enhancement New features/functionality Tenable.ad Tenable.ad Package unit-testing This issue requires new/updated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants