Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support to TenableAD category APIs #496

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

dheerajrp
Copy link
Contributor

@dheerajrp dheerajrp commented Dec 8, 2021

Description

Added Tenable.AD category APIs

Methods available:

  • Retrieve all category instances - list
  • Get category instance by id - details

Updated docs to support category API details.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tests added to test all the category endpoints and their schema.
  • Sphinx build for doc

Test Configuration:

  • Python Version(s) Tested: 3.9
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dheerajrp dheerajrp requested review from SteveMcGrath and a team December 8, 2021 10:59
@SteveMcGrath SteveMcGrath merged commit 4e32233 into master Dec 8, 2021
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad-category branch December 8, 2021 16:22
@SteveMcGrath SteveMcGrath added this to the 1.5 milestone Dec 10, 2021
@SteveMcGrath SteveMcGrath added enhancement New features/functionality unit-testing This issue requires new/updated tests documentation Documentation issues Tenable.ad Tenable.ad Package labels Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issues enhancement New features/functionality Tenable.ad Tenable.ad Package unit-testing This issue requires new/updated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants