Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docstrings and removed extra lines in ad packages #509

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

dheerajrp
Copy link
Contributor

@dheerajrp dheerajrp commented Dec 29, 2021

Description

  1. Updated the docstrings for ad packages -
  • directory
  • widget
  1. Removed unwanted lines from -
  • schema file of widgets package.
  1. Updated with f-strings where they were missed in the following packages-
  • directory
  • category
  • checker
  • dashboard
  • infrastructure
  • SAML configuration

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Sphinx build

Test Configuration:

  • Python Version(s) Tested: 3.9.0
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dheerajrp dheerajrp requested review from SteveMcGrath and a team December 29, 2021 10:16
@dheerajrp dheerajrp force-pushed the bugfix/update_docstrings branch from fbc1e03 to 6aa7853 Compare December 29, 2021 11:38
@SteveMcGrath SteveMcGrath merged commit fe07e83 into master Dec 29, 2021
@SteveMcGrath SteveMcGrath deleted the bugfix/update_docstrings branch December 29, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants