Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TenableAD Attack APIs #522

Merged
merged 2 commits into from
May 21, 2024

Conversation

tushar-balwani
Copy link
Contributor

Description

Added Tenable.AD Attack APIs

  • Get all attacks(list)

updated docs to support attack api details
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests for attack endpoints to test responses
  • Added schema tests for testing payload inputs and response dict validation

Test Configuration:

  • Python Version(s) Tested: 3.8.6
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tushar-balwani tushar-balwani requested review from SteveMcGrath and a team January 18, 2022 14:25
Comment on lines 10 to 12
@pre_load
def convert(self, data, **kwargs):
return convert_keys_to_camel(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer necessary per #526

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed pre_load method

Comment on lines 47 to 49
@pre_load
def convert(self, data, **kwargs):
return convert_keys_to_camel(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer necessary per #526

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed pre_load method

@tushar-balwani tushar-balwani force-pushed the feature/tenable.ad.attack branch from c2f78b6 to 1f28423 Compare January 20, 2022 07:41
fixed schema test

updated schema file

removed unused imports
@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 21, 2024 19:24
Copy link

@SteveMcGrath SteveMcGrath merged commit 5336d1b into master May 21, 2024
16 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad.attack branch May 21, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants