Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for TenableAD AD Object APIs #525

Merged
merged 2 commits into from
May 21, 2024
Merged

Added support for TenableAD AD Object APIs #525

merged 2 commits into from
May 21, 2024

Conversation

tushar-balwani
Copy link
Contributor

Description

Added Tenable.AD AD Object APIs

  • Get ad-object instance by id. (details)
  • Retrieve an AD object by id that have deviances for a specific profile and checker (details_by_profile_and_checker)
  • Get ad-object instance by id. (details_by_event)
  • Get one ad-object changes between a given event and the event which precedes it (get_changes)
  • Search all AD objects having deviances by profile by checker (search_all)

updated docs to support ad object api details

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Added tests for ad object endpoints to test responses
  • Added schema tests for testing payload inputs and response dict validation

Test Configuration:

  • Python Version(s) Tested: 3.8.6
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tushar-balwani tushar-balwani requested review from SteveMcGrath and a team January 19, 2022 13:29
SteveMcGrath
SteveMcGrath requested changes Jan 19, 2022
View reviewed changes
tenable/ad/ad_object/schema.py Outdated
Comment on lines 44 to 47

@pre_load
def convert(self, data, **kwargs):
return convert_keys_to_camel(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#526 negates this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed pre_load method

tenable/ad/ad_object/schema.py Outdated
Comment on lines 26 to 28
@pre_load
def convert(self, data, **kwargs):
return convert_keys_to_camel(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#526 negates this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed pre_load method

tenable/ad/ad_object/schema.py Outdated
Comment on lines 16 to 18
@pre_load
def convert(self, data, **kwargs):
return convert_keys_to_camel(data)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#526 negates this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed pre_load method

@tushar-balwani tushar-balwani force-pushed the feature/tenable.ad.ad_object branch 2 times, most recently from faceefd to 60d14f4 Compare January 20, 2022 09:28
@tushar-balwani tushar-balwani marked this pull request as draft January 25, 2022 08:30
@tushar-balwani tushar-balwani force-pushed the feature/tenable.ad.ad_object branch 2 times, most recently from 9ae5477 to e27481d Compare January 25, 2022 13:43
@tushar-balwani tushar-balwani marked this pull request as ready for review January 25, 2022 15:15
@tushar-balwani @SteveMcGrath
Added feature - TenableAD AD Object APIs
e021240 
updated schema file

removed unused imports

implemented AD object iterator for search all method

fixed broken test
@SteveMcGrath SteveMcGrath force-pushed the feature/tenable.ad.ad_object branch from e27481d to e021240 Compare April 29, 2022 17:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 21, 2024 19:44
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@SteveMcGrath SteveMcGrath merged commit 321eed7 into master May 21, 2024
16 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/tenable.ad.ad_object branch May 21, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveMcGrath SteveMcGrath SteveMcGrath approved these changes

@tomeara tomeara Awaiting requested review from tomeara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tushar-balwani @SteveMcGrath