bugfix: pyTenable crashes if srcInterface or dstInterface not null #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addressed a bug causing a crash in when events->srcInterface or events->dstInterface was not null upon query completion. The issue was traced back to incorrect usage of the marshmallow package. Note: In Tenable.OT version 3.17, a bug existed where events->srcInterface and dstInterface consistently returned null. Due to this behavior, the current bug did not manifest itself during that version Additionally, added the retrieval of required nodes from dstInterface, ensuring that all necessary nodes are now properly obtained.
elad-indegy
approved these changes
Jan 22, 2024
|
|
||
|
|
||
| @dataclass | ||
| class IP: |
There was a problem hiding this comment.
Use this class also in tenable/ot/schema/events.py line:124 (dst_ip) and on line:139 (src_ip)
elad-indegy
approved these changes
Feb 5, 2024
|
@saizinbud The changes look good to me. Could you also add tests? |
* Add srcInterface and dstInterface fields to OT test * Revert change of last commit - dst_ip, src_ip should remain IPv4Address and cannot be converted to IP class * Change directAsset field of NetworkInterface to ID class * Move ID, IDList classes to base.py * Remove Lists from src_interface and dst_interface - These fields cannot return lists
aseemsavio
approved these changes
Feb 13, 2024
varap11
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressed a bug causing a crash in when events->srcInterface or events->dstInterface was not null upon query completion. The issue was traced back to incorrect usage of the marshmallow package.
Note: In Tenable.OT version 3.17, a bug existed where events->srcInterface and dstInterface consistently returned null. Due to this behavior, the current bug did not manifest itself during that version
Additionally, added the retrieval of required nodes from dstInterface, ensuring that all necessary nodes are now properly obtained.
Type of change
How Has This Been Tested?
Run local tests and tested against a Tenable.OT machine
Test Configuration: