Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit WAS exclude (backwards compat) #763

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

SteveMcGrath
Copy link
Contributor

Description

Adds implicit WAS data exclusion filter to TSC analysis calls when querying non-individual vuln data. This should salve for backwards compatability issues with TSC 6.2.x and later.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Manual testing of the implicit filter inclusion.

Test Configuration:

  • Python Version(s) Tested: 3.9.9
  • Tenable.sc version (if necessary): 6.3.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team March 11, 2024 17:02
@SteveMcGrath SteveMcGrath requested a review from a team as a code owner April 10, 2024 13:15
Copy link

sonarcloud bot commented Apr 10, 2024

@SteveMcGrath SteveMcGrath merged commit ca1a431 into master Apr 10, 2024
15 checks passed
@SteveMcGrath SteveMcGrath deleted the bugfix/implicit_was_exclude branch April 10, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants