Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat/Ai-24374]-tenable-one-list-asset-properties #880

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

naumraviz
Copy link
Contributor

@naumraviz naumraviz commented Feb 13, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Python Version(s) Tested:
  • Tenable.sc version (if necessary):

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@naumraviz naumraviz requested a review from a team as a code owner February 13, 2025 14:24
@SteveMcGrath
Copy link
Contributor

No testing yet

@SteveMcGrath SteveMcGrath marked this pull request as draft February 13, 2025 15:17
Copy link

gitguardian bot commented Feb 15, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@naumraviz naumraviz force-pushed the AI-24374_tenable_one_list_assets_properties branch from 861aec4 to cdb1fec Compare February 15, 2025 13:17
@naumraviz naumraviz marked this pull request as ready for review February 15, 2025 13:18
@naumraviz
Copy link
Contributor Author

@SteveMcGrath I am not sure why coverage fails. I am considering opening a new branch/PR

here is the error -

Run orgoro/coverage@v3.2
comparing commits: base b4af3a9bc7232c9e25181fb51f48f8a2408c4dc3 <> head 5b968982109457b1ccaa8ec682872f0c5bea8019
git new files: ["tenable/one/__init__.py","tenable/one/assets/__init__.py","tenable/one/assets/api.py","tenable/one/assets/schema.py","tests/one/__init__.py","tests/one/assets/test_assets_api.py","tests/one/conftest.py"] modified files: []
source: tenable
Results
HttpError: Resource not accessible by integration
    at /home/runner/work/_actions/orgoro/coverage/v3.2/webpack:/typescript-action/node_modules/@octokit/request/dist-node/index.js:86:1
    at processTicksAndRejections (node:internal/process/task_queues:95:5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants