Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fixed a bug in checkIpForward" #322

Merged
merged 1 commit into from
Sep 14, 2020

Conversation

cesar-rodriguez
Copy link
Contributor

@cesar-rodriguez cesar-rodriguez commented Sep 14, 2020

Reverts #321

The #321 change worked locally, but caused an issue once merged to master

$ terrascan scan -t gcp
2020-09-14T14:06:26.303-0400    error   opa/engine.go:206       error compiling rego files{rule 15 0 checkIpForward <nil>} {raw rego 15 0 package accurics

<no value>[api.id]
{
     api := input.google_compute_instance[_]
     api.config.can_ip_forward == true
}

 <nil>} {error 25 0  1 error occurred: checkIpForward:3: rego_parse_error: unexpected lt token
        <no value>[api.id]
        ^}
2020-09-14T14:06:26.303-0400    error   opa/engine.go:242       error compiling rego files{policy path 15 0 /Users/therasec/.terrascan/pkg/policies/opa/rego/gcp <nil>}
2020-09-14T14:06:26.303-0400    error   opa/engine.go:56        failed to initialize OPA policy engine
2020-09-14T14:06:26.303-0400    error   runtime/executor.go:88  failed to create policy engine. error: 'failed to initialize OPA policy engine'

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Sep 14, 2020

Codecov Report

Merging #322 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #322   +/-   ##
=======================================
  Coverage   59.36%   59.36%           
=======================================
  Files          48       48           
  Lines         982      982           
=======================================
  Hits          583      583           
  Misses        350      350           
  Partials       49       49           

@williepaul williepaul self-requested a review September 14, 2020 18:24
@williepaul williepaul merged commit cbe6c35 into master Sep 14, 2020
@williepaul williepaul deleted the revert-321-bugfix/fix-checkIpForward-rule branch September 14, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants