AWS new Categories #581
Merged
AWS new Categories #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-gogia
suggested changes
Mar 5, 2021
There was a problem hiding this comment.
Hi, some changes are required. Please look into following logs for reference. Some issues may be due to tiny spelling or spacing error(s):
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_api_gateway_rest_api
MEDIUM -------- MEDIUM
AC-AW-IS-AP-M-0010 -------- AC-AW-IS-AP-M-0010
Infrastructure Security -------- Infrastructure Security
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_cloudfront_distribution
Medium -------- LOW
AC-AW-IS-CD-M-0026 -------- AC-AW-IS-CD-L-0026
Infrastructure Security -------- Infrastructure Security
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_cloudfront_distribution
Medium -------- Medium
AC-AW-IS-CD-M-1186 -------- AC-AW-IS-CD-M-0032
Infrastructure Security -------- Infrastructure Security
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_ecs_task_definition
HIGH -------- HIGH
AC-AW-DP-EK-H-0088 -------- AC-AW-DP-EK-H-0094
Data Protection -------- Data Protection
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_elasticsearch_domain
MEDIUM -------- HIGH
AC-AW-DP-ED-H-0109 -------- AC-AW-DP-ED-H-0109
Data Protection -------- Data Protection
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_account_password_policy
MEDIUM -------- Low
AC-AW-CV-IA-L-0127 -------- AC-AW-CV-IA-L-0127
Compliance Validation -------- Compliance Validation
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_account_password_policy
MEDIUM -------- MEDIUM
AAC-AW-CV-IA-M-0130 -------- AC-AW-CV-IA-M-0130
Compliance Validation -------- Compliance Validation
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_account_password_policy
LOW -------- LOW
AC-AW-CV-IA-M-0131 -------- AC-AW-CV-IA-L-0131
Compliance Validation -------- Compliance Validation
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_group_policy
HIGH -------- HIGH
AC-AW-IA-H-0136 -------- AC-AW-IA-IG-H-0136
Identity and Access Management -------- Identity and Access Management
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_role
HIGH -------- HIGH
AC-AW-IA-H-0139 -------- AC-AW-IA-IR-H-0139
Identity and Access Management -------- Identity and Access Management
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_role_policy
HIGH -------- HIGH
AC-AW-IA-H-0140 -------- AC-AW-IA-IP-H-0140
Identity and Access Management -------- Identity and Access Management
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_kms_key
HIGH -------- HIGH
AC-AW-RE-KK-H-0152 -------- AC-AW-RE-KK-H-0152
Resilence -------- Resilience
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_launch_configuration
HIGH -------- HIGH
AAC-AW-DP-LC-H-0162 -------- AC-AW-DP-LC-H-0162
Data Protection -------- Data Protection
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_launch_configuration
HIGH -------- HIGH
AAC-AW-DP-LC-H-0163 -------- AC-AW-DP-LC-H-0163
Data Protection -------- Data Protection
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_security_group
HIGH -------- Low
AC-AW-IS-SG-L-0312 -------- AC-AW-IS-SG-L-0312
Infrastructure Security -------- Infrastructure Security
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_security_group
HIGH -------- HIGH
AC-AW-IS-SG-M-0220 -------- AC-AW-IS-SG-H-0220
Infrastructure Security -------- Infrastructure Security
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_security_group
MEDIUM -------- MEDIUM
AC-AW-IS-SG-M-0270 -------- AC-AW-IS-SG-M-0304
Infrastructure Security -------- Infrastructure Security
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_security_group
MEDIUM -------- MEDIUM
AC-AW-IS-SG-M-0284 -------- AC-AW-IS-SG-M-0286
Infrastructure Security -------- Infrastructure Security
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_vpc
MEDIUM -------- MEDIUM
AC-AW-SP-VP-M-0363 -------- AC-AW-SP-VP-M-0363
Logging and Monitoring -------- Security Best Practices
Codecov Report
@@ Coverage Diff @@
## master #581 +/- ##
=======================================
Coverage 77.65% 77.65%
=======================================
Files 102 102
Lines 2524 2524
=======================================
Hits 1960 1960
Misses 420 420
Partials 144 144 |
gaurav-gogia
suggested changes
Mar 6, 2021
There was a problem hiding this comment.
Just a couple more changes are required:
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_account_password_policy
MEDIUM -------- MEDIUM
AAC-AW-CV-IA-M-0130 -------- AC-AW-CV-IA-M-0130
Compliance Validation -------- Compliance Validation
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_iam_policy
HIGH -------- HIGH
AC-AW-IA-H-0137 -------- AC-AW-IA-IP-H-0137
Identity and Access Management -------- Identity and Access Management
/Users/gauravgogia/Desktop/terrascan/pkg/policies/opa/rego/aws/aws_security_group
MEDIUM -------- MEDIUM
AC-AW-IS-SG-M-0304 -------- AC-AW-IS-SG-M-0270
Infrastructure Security -------- Infrastructure Security
|
Kudos, SonarCloud Quality Gate passed!
|
gaurav-gogia
approved these changes
Mar 6, 2021
devang-gaur
approved these changes
Mar 9, 2021
kanchwala-yusuf
pushed a commit
to kanchwala-yusuf/terrascan
that referenced
this pull request
Mar 9, 2021
This reverts commit cca6d2f.
cesar-rodriguez
pushed a commit
that referenced
this pull request
Mar 9, 2021
* Revert "New Policies for Azure & Category Updates. (#580)" This reverts commit 02d312e. * Revert "Terrascan K8s New categories and ruleRef ID changes (#583)" This reverts commit 6bdcf0c. * Revert "Updating Rule reference Id's and Policy categories (#582)" This reverts commit dbb5a91. * Revert "AWS new Categories (#581)" This reverts commit cca6d2f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes: