Support for spaces in policy reference_id

[nasir-rabbani]

1. Updated regex to skip rules with spaces in reference_id.
2. Added test cases for reference_id with spaces

[codecov]

Codecov Report

Merging #833 (daacad6) into master (95aba12) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
- Coverage   78.22%   78.20%   -0.03%     
==========================================
  Files         162      164       +2     
  Lines        4354     4359       +5     
==========================================
+ Hits         3406     3409       +3     
- Misses        734      735       +1     
- Partials      214      215       +1     

Impacted Files	Coverage Δ
pkg/utils/skip_rules.go	93.33% <100.00%> (-0.42%)	⬇️
pkg/policy/opa/engine.go	59.36% <0.00%> (-5.04%)	⬇️
pkg/iac-providers/tfplan/v1/load-file.go	74.19% <0.00%> (-3.59%)	⬇️
pkg/policy/types.go	100.00% <0.00%> (ø)
pkg/iac-providers/output/types.go	100.00% <0.00%> (ø)
pkg/filters/filter-specs.go	92.30% <0.00%> (ø)
pkg/filters/filters.go	100.00% <0.00%> (ø)
pkg/runtime/executor.go	89.65% <0.00%> (+0.08%)	⬆️
pkg/utils/policy.go	70.00% <0.00%> (+20.00%)	⬆️

[devang-gaur]

I'd be great if you could also add some e2e tests for this. since this is a functional change/enhancement.

[patilpankaj212]

Hi @nasir-rabbani, I think we can now add test in the policies package and verify that all the reference id's / id's pass the regex.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

[patilpankaj212]

we can push this PR for now, but when we add tests for policies, we would need to ensure that spaces are not allowed in the rule ID / reference ID.