Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug: not support lowercase keys in response header #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix bug: not support lowercase keys in response header #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/response/base_resp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
#include "cos_sys_config.h"
#include "util/string_util.h"

#include "Poco/String.h"

namespace qcloud_cos {

std::string BaseResp::GetHeader(const std::string& key) const {
Expand All @@ -38,41 +40,78 @@ void BaseResp::ParseFromHeaders(const std::map<std::string, std::string>& header
m_headers = headers;
std::map<std::string, std::string>::const_iterator itr;
itr = headers.find(kReqHeaderContentLen);
if (headers.end() == itr) {
/* Keys in headers maybe full lowercase in some environment
* e.g. headers = {
* { "content-length": "5" },
* { "content-type": "text/plain" }
* }
*
* Variables (kReqHeader*) is defined by initial capitalization in "cos_params.h"
* const std::string kReqHeaderContentLen = "Content-Length";
* const std::string kReqHeaderContentType = "Content-Type";
*
* When doesn't find the exact value by initial capitalization key,
* This code will find the value by lowercase key again
*/
itr = headers.find(Poco::toLower(kReqHeaderContentLen));
}
if (headers.end() != itr) {
m_content_length = StringUtil::StringToUint64(itr->second);
}

itr = headers.find(kReqHeaderContentType);
if (headers.end() == itr) {
itr = headers.find(Poco::toLower(kReqHeaderContentType));
}
if (headers.end() != itr) {
m_content_type = itr->second;
}

itr = headers.find(kReqHeaderEtag);
if (headers.end() == itr) {
itr = headers.find(Poco::toLower(kReqHeaderEtag));
}
if (headers.end() != itr) {
m_etag = StringUtil::Trim(itr->second, "\"");
}

itr = headers.find(kReqHeaderConnection);
if (headers.end() == itr) {
itr = headers.find(Poco::toLower(kReqHeaderConnection));
}
if (headers.end() != itr) {
m_connection = itr->second;
}

itr = headers.find(kReqHeaderDate);
if (headers.end() == itr) {
itr = headers.find(Poco::toLower(kReqHeaderDate));
}
if (headers.end() != itr) {
m_date = itr->second;
}

itr = headers.find(kReqHeaderServer);
if (headers.end() == itr) {
itr = headers.find(Poco::toLower(kReqHeaderServer));
}
if (headers.end() != itr) {
m_server = itr->second;
}

itr = headers.find(kReqHeaderXCosReqId);
if (headers.end() == itr) {
itr = headers.find(Poco::toLower(kReqHeaderXCosReqId));
}
if (headers.end() != itr) {
m_x_cos_request_id = itr->second;
}

itr = headers.find(kReqHeaderXCosTraceId);
if (headers.end() == itr) {
itr = headers.find(Poco::toLower(kReqHeaderXCosTraceId));
}
if (headers.end() != itr) {
m_x_cos_trace_id = itr->second;
}
Expand Down