Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModifyBid missing owner validation #109

Merged
merged 3 commits into from
Feb 28, 2022

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Feb 28, 2022

Description

closes: #108

Tasks

  • Add owner validation in ModifyBid
  • Add test cases to cover validation checks for ModifyBid

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Feb 28, 2022
@jaybxyz jaybxyz marked this pull request as ready for review February 28, 2022 06:08
@jaybxyz jaybxyz merged commit d0cc768 into tendermint:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix ModifyBid to validate the owner
1 participant