Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add make targets #189

Merged
merged 3 commits into from
Aug 5, 2022
Merged

add make targets #189

merged 3 commits into from
Aug 5, 2022

Conversation

aljo242
Copy link
Contributor

@aljo242 aljo242 commented Jul 26, 2022

Description

Adds new make targets:

  • make format
  • make lint

These targets help with maintainability end for enforcing better style over time.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@aljo242
Copy link
Contributor Author

aljo242 commented Jul 26, 2022

Only error is CodeCov

Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these two useful targets!

Makefile Show resolved Hide resolved
@jaybxyz
Copy link
Contributor

jaybxyz commented Aug 4, 2022

@aljo242 Before we merge this PR, can you change all targets that use starport to ignite in Makefile?

@jaybxyz jaybxyz merged commit 6094ae6 into tendermint:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants