Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test cases for batchAuctino and modifyBid #96

Merged
merged 11 commits into from
Feb 22, 2022
Merged

feat: add test cases for batchAuctino and modifyBid #96

merged 11 commits into from
Feb 22, 2022

Conversation

jeonghoyeo7
Copy link
Contributor

Description

closes: #88

Tasks

  • Make TestMsgCreateBatchAuction, TestMsgModifyBid
  • Add (msg MsgModifyBid) GetBidder()
  • Modify to use Type, Price, and Coin and to delete PayingCoin in Bid state.
  • Modify the related specs.

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jeonghoyeo7 jeonghoyeo7 changed the title Jeongho/88 add test cases for batch modify Feat: add test cases for batchAuctino and modifyBid Feb 22, 2022
@jeonghoyeo7 jeonghoyeo7 changed the title Feat: add test cases for batchAuctino and modifyBid feat: add test cases for batchAuctino and modifyBid Feb 22, 2022
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

x/fundraising/spec/02_state.md Outdated Show resolved Hide resolved
@jaybxyz jaybxyz merged commit b9f3277 into tendermint:main Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: add test cases for MsgCreateBatchAuction and MsgModifyBid
2 participants