Make amino build on 32bit architectures #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- explicitly type constant in time encoding - use math.MaxInt32 in int tests to seed the fuzzer
liamsi
force-pushed
the
build_on_32bit_again
branch
from
1e1ceba
to
2757cf3
Compare
liamsi
force-pushed
the
build_on_32bit_again
branch
from
d42209f
to
b653908
Compare
liamsi
changed the title
Co-Authored-By: Liamsi <Ismail.Khoffi@gmail.com>
Co-Authored-By: Liamsi <Ismail.Khoffi@gmail.com>
greg-szabo
approved these changes
Nov 7, 2018
|
Thanks for the review @greg-szabo. I think we were seeing errors in encoder.go because it was using that same variables defined in decoder.go. After #243 gets approved, I'll tag another release, which should make the arm/32bit builds work again. |
liamsi
added a commit
that referenced
this pull request
Nov 11, 2018
* add contribution guidelines - minimal changes to ensure proto3 compat. for unsigned ints (int, int32, int64) * Add changes to decode ints, too * Delete outdated tests (covered by new table driven test) * Add overflow checks for int & int32 * prep release: update changelog * Make amino build on 32bit architectures (#242) * fix int overflows that happen on 32bit systems - explicitly type constant in time encoding - use math.MaxInt32 in int tests to seed the fuzzer * Add --concrete-name option to aminoscan
This was referenced Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some constants in encoder.go are interpreted as
intby default and they overflow ints on 32bit machines: encoder.goSimilarly some values that seed the fuzzer: here for instance.
The first makes tendermint builds fail on certain architectures. This PR is a quick-fix for this issue.
The changes made in this PR were tested (and fuzzed) with a i686 docker image (and locally for 64bit).