Lint Galore #281
Merged
Lint Galore #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added a few linters ref #258 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
melekes
reviewed
Aug 6, 2019
| @@ -260,7 +260,7 @@ func TestUnmarshalJSON(t *testing.T) { | |||
| }, | |||
| { // #9 | |||
| `[1, "2", ["foo", "bar"]]`, | |||
| new([]interface{}), nil, "Unregistered", | |||
| new([]interface{}), nil, "unregistered interface interface {}", | |||
There was a problem hiding this comment.
are you sure Unregistered == unregistered interface interface {}?
| @@ -43,7 +43,7 @@ func TestMarshalJSON(t *testing.T) { | |||
| {&oneExportedField{A: "Z"}, `{"A":"Z"}`, ""}, // #6 | |||
| {[]string{"a", "bc"}, `["a","bc"]`, ""}, // #7 | |||
| {[]interface{}{"a", "bc", 10, 10.93, 1e3}, | |||
| ``, "Unregistered"}, // #8 | |||
| ``, "unregistered"}, // #8 | |||
There was a problem hiding this comment.
what about this place?
Unregistered == unregistered interface interface {}?
There was a problem hiding this comment.
This is correct because the error is now lowercase and not capitalized
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
golangcibot
reviewed
Aug 6, 2019
melekes
approved these changes
Aug 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #258
Signed-off-by: Marko Baricevic marbar3778@yahoo.com