-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lint Galore #281
Lint Galore #281
Conversation
- added a few linters ref #258 Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
@@ -260,7 +260,7 @@ func TestUnmarshalJSON(t *testing.T) { | |||
}, | |||
{ // #9 | |||
`[1, "2", ["foo", "bar"]]`, | |||
new([]interface{}), nil, "Unregistered", | |||
new([]interface{}), nil, "unregistered interface interface {}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure Unregistered == unregistered interface interface {}?
@@ -43,7 +43,7 @@ func TestMarshalJSON(t *testing.T) { | |||
{&oneExportedField{A: "Z"}, `{"A":"Z"}`, ""}, // #6 | |||
{[]string{"a", "bc"}, `["a","bc"]`, ""}, // #7 | |||
{[]interface{}{"a", "bc", 10, 10.93, 1e3}, | |||
``, "Unregistered"}, // #8 | |||
``, "unregistered"}, // #8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about this place?
Unregistered == unregistered interface interface {}?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct because the error is now lowercase and not capitalized
Co-Authored-By: Anton Kaliaev <anton.kalyaev@gmail.com>
ref #258
Signed-off-by: Marko Baricevic marbar3778@yahoo.com