-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more linting #296
Add more linting #296
Conversation
- added more linting Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
9ca9bdd
to
1b3315e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -331,7 +331,7 @@ func (cdc *Codec) UnmarshalBinaryLengthPrefixedReader(r io.Reader, ptr interface | |||
} | |||
l = int64(u64) | |||
if l < 0 { | |||
_ = errors.Errorf( | |||
_ = errors.Errorf( //nolint:errcheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking at this as well, with amino being a bit touchy I didn't want to change to much stuff in this PR so I left it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right. But this code does not do anything, so maybe we should comment it completely.
Signed-off-by: Marko Baricevic marbar3778@yahoo.com