Add more linting #296
Merged
Add more linting #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added more linting Signed-off-by: Marko Baricevic <marbar3778@yahoo.com>
tac0turtle
force-pushed
the
marko/linting
branch
from
9ca9bdd
to
1b3315e
Compare
melekes
reviewed
Nov 12, 2019
tessr
approved these changes
Nov 12, 2019
melekes
reviewed
Nov 12, 2019
| @@ -331,7 +331,7 @@ func (cdc *Codec) UnmarshalBinaryLengthPrefixedReader(r io.Reader, ptr interface | |||
| } | |||
| l = int64(u64) | |||
| if l < 0 { | |||
| _ = errors.Errorf( | |||
| _ = errors.Errorf( //nolint:errcheck | |||
There was a problem hiding this comment.
I was looking at this as well, with amino being a bit touchy I didn't want to change to much stuff in this PR so I left it
There was a problem hiding this comment.
Right. But this code does not do anything, so maybe we should comment it completely.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Marko Baricevic marbar3778@yahoo.com