Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deterministic environment, scripts for proto, swagger generation #192

Closed
4 tasks
dongsam opened this issue Mar 23, 2021 · 0 comments · Fixed by #216
Closed
4 tasks

Deterministic environment, scripts for proto, swagger generation #192

dongsam opened this issue Mar 23, 2021 · 0 comments · Fixed by #216
Assignees
@hallazzang

Comments

@dongsam
Copy link
Contributor

dongsam commented Mar 23, 2021 •
edited by hallazzang
Loading

Summary

more deterministic environment, scripts for proto, swagger generation

Problem Definition

liquidity/contrib/devtools/proto-tools-installer.sh

Lines 9 to 11 in d77c376

BUF_VERSION=0.11.0
PROTOC_VERSION=3.13.0
PROTOC_GRPC_GATEWAY_VERSION=1.16.0

Currently, proto-tools does not enforce the above versions, so different pb.go, swagger.json results are produced depending on the local environment

Proposal

Add logic that forces version to proto-tools or use environments such as docker

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make proto-gen and proto-swagger-gen to use docker b-harvest/liquidity
3 participants
@dongsam @hallazzang @defihyung