Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make proto-gen and proto-swagger-gen to use docker #216

Merged

Conversation

hallazzang
Copy link
Contributor

Description

Make proto-gen and proto-swagger-gen make command to use docker for deterministic stub generation.
As cosmos/cosmos-sdk#7933 is an ongoing issue, we use slightly modified Dockerfile for our own use and publish it onto Docker Hub(bharvest/liquidity-proto-gen).
Later, it may use updated tendermintdev/sdk-proto-gen image instead.

closes: #192


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

it makes proto stub generation more deterministic
@hallazzang hallazzang requested a review from dongsam April 7, 2021 07:10
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #216 (2415f99) into develop (5c05566) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #216   +/-   ##
========================================
  Coverage    83.43%   83.43%           
========================================
  Files           20       20           
  Lines         2349     2349           
========================================
  Hits          1960     1960           
  Misses         209      209           
  Partials       180      180           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c05566...2415f99. Read the comment docs.

@hallazzang hallazzang self-assigned this Apr 7, 2021
@hallazzang
Copy link
Contributor Author

As cosmos/cosmos-sdk#9064 merged, we can use tendermintdev/sdk-proto-gen image instead of bharvest/liquidity-proto-gen but in tendermintdev/sdk-proto-gen, grpc gateway version is set to 1.14.7 while we need to use 1.16.0.
Maybe creating new issue in cosmos-sdk will be the solution but for now we will use bharvest/liquidity-proto-gen.
Also note that there's no github workflow that builds and pushes our docker image(all done manually).

@hallazzang hallazzang marked this pull request as ready for review April 7, 2021 11:03
@dongsam dongsam merged commit df341a7 into tendermint:develop Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deterministic environment, scripts for proto, swagger generation
2 participants