Use Docker to generate swagger files #9064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hallazzang
requested review from
aaronc,
alessio and
alexanderbez
as code owners
tac0turtle
approved these changes
Apr 7, 2021
tac0turtle
added
the
A:automerge
amaury1093
reviewed
Apr 7, 2021
There was a problem hiding this comment.
How did you test?
make proto-swagger-gen
/usr/local/bin/docker run --rm -v /Users/amaury/Workspace/regen/cosmos-sdk:/workspace --workdir /workspace tendermintdev/sdk-proto-gen sh ./scripts/protoc-swagger-gen.sh
Unable to find image 'tendermintdev/sdk-proto-gen:latest' locally
latest: Pulling from tendermintdev/sdk-proto-gen
ba3557a56b15: Pull complete
34a078c6c131: Pull complete
e78f90fd1d94: Pull complete
efdc4f024afd: Pull complete
74b7f786c072: Pull complete
e056034dfc96: Pull complete
9c8b2c21c4ca: Pull complete
ab2da8730ae7: Pull complete
Digest: sha256:372dce7be2f465123e26459973ca798fc489ff2c75aeecd814c0ca8ced24faca
Status: Downloaded newer image for tendermintdev/sdk-proto-gen:latest
./scripts/protoc-swagger-gen.sh: line 24: swagger-combine: not found
make: *** [proto-swagger-gen] Error 127
|
@AmauryM Sorry, I forgot to mention about that. I've found that After this pull request has merged, the image on Docker Hub will be updated too and |
amaury1093
approved these changes
Apr 7, 2021
|
Thanks @hallazzang for the PR! |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use Docker to generate swagger files.
Also change deprecated commands to new commands and re-generate protobuf stubs and swagger documentation using
make proto-genandmake proto-swagger-gen.closes: #7933
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes