Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Fix warning for dynamic trait objects #83

Closed
wants to merge 1 commit into from

Conversation

amanusk
Copy link
Contributor

@amanusk amanusk commented Aug 22, 2019

Fix trait objects without an explicit dyn are deprecated warning

Starting rust stable version 1.37.0, the old syntax for trait object emits errors.
Similarly, the updated protobuf version generates files adhering to the new standard.

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • Reviewed Files changed in the github PR explorer

  • Bump Tendermint & ABCI version in README.md if version was updated


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Update protobuf version
Fix warnings
@tomtau tomtau requested review from liamsi, tomtau and tac0turtle and removed request for liamsi August 22, 2019 08:35
Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amanusk thank you for your contribution!
The changes look good to me, but could you open the PR against the 'develop' branch: https://github.com/tendermint/rust-abci/tree/develop ? We'll make a release from it later

@tomtau tomtau closed this Aug 22, 2019
@amanusk amanusk mentioned this pull request Aug 22, 2019
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants