Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the reward pool if no reward is set #522

Closed
lumtis opened this issue Feb 16, 2022 · 0 comments · Fixed by #540
Closed

Remove the reward pool if no reward is set #522

lumtis opened this issue Feb 16, 2022 · 0 comments · Fixed by #540
Assignees
@Pantani
Labels
reward Related to reward module
Milestone
Milestone 3

Comments

@lumtis
Copy link
Contributor

lumtis commented Feb 16, 2022

Currently MsgSetRewards is invalid for empty coins

We should add the behavior of removing the reward pool if rewards are specified as zero coins

Alternative:

Introducing a new message like MsgUnsetRewards although I think it add unnecessary complexity for the chain. The name difference can be handled in the client

Operation is still impossible if launch is triggered
@lumtis lumtis added the reward Related to reward module label Feb 16, 2022
@lumtis lumtis added this to the Milestone 3 milestone Feb 16, 2022
@lumtis lumtis linked a pull request Feb 18, 2022 that will close this issue
feat(reward): enable empty reward coins for MsgSetRewards #540
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pantani Pantani

Labels
reward Related to reward module
Projects
None yet
Milestone
Milestone 3
Development

Successfully merging a pull request may close this issue.

feat(reward): enable empty reward coins for MsgSetRewards tendermint/spn
2 participants
@Pantani @lumtis