-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(reward): enable empty reward coins for MsgSetRewards
#540
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #540 +/- ##
========================================
Coverage 11.05% 11.06%
========================================
Files 234 234
Lines 54129 54131 +2
========================================
+ Hits 5985 5987 +2
+ Misses 47969 47968 -1
- Partials 175 176 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can totally remove the reward pool from the store if rewards are set to 0
I think we can also have the same behavior when the height is set to 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLI works well 👍
What does this PR does?
Enable empty coins reward in
MsgSetRewards
so we can remove all rewards for a campaignHow to test?