test(campaign): simulation improvements
#726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
requested review from
fadeev,
ilgooz,
lumtis,
Pantani,
ivanovpetr and
aljo242
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #726 +/- ##
===========================================
- Coverage 11.20% 11.19% -0.01%
===========================================
Files 278 278
Lines 60787 60780 -7
===========================================
- Hits 6809 6804 -5
+ Misses 53793 53792 -1
+ Partials 185 184 -1
|
aljo242
approved these changes
Apr 14, 2022
lumtis
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #358
Closes #719
I've decided for manually setting the two send_enabled params instead of
banktypes.DefaultParams()to avoid potentially overriding other params (unintentionally) in bank that might be added in the future.