test: ensure only sdk.DefaultBondDenom is used for fees in our modules simulation
#743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giunatale
requested review from
fadeev,
ilgooz,
lumtis,
Pantani,
ivanovpetr and
aljo242
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #743 +/- ##
===========================================
+ Coverage 11.44% 11.47% +0.03%
===========================================
Files 278 279 +1
Lines 60780 60803 +23
===========================================
+ Hits 6955 6976 +21
- Misses 53663 53664 +1
- Partials 162 163 +1
|
aljo242
approved these changes
Apr 22, 2022
Yes, for |
lumtis
reviewed
Apr 22, 2022
lumtis
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #369
This PR does not really fix #369, as explained in the issue itself.
However, we at least switch over using only the
sdk.DefaultBondDenomcoin for fees in our modules' simulation.Problem will stil exist however for modules we pull from the cosmos-sdk, so
out of gaswill still occasionally occur (and it's highly likely to occur for large simulations), but I propose we close #369 as this can't really be avoided.I've also made sure we initialize the
randseed inTestAppStateDeterminism, and fixed an error in how we were selecting auctions formsgParticipatesimulation.Apologies if I may have bundled too many things together in this PR.