Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade fundraising to 0.3.0 #771

Merged
merged 8 commits into from
May 9, 2022
Merged

Conversation

lumtis
Copy link
Contributor

@lumtis lumtis commented May 8, 2022

  • Upgrade fundraising import version to 0.3.0
  • Remove create and cancel auction operations in participation as fundraising now implements its own simulations

@lumtis lumtis linked an issue May 8, 2022 that may be closed by this pull request
Copy link
Contributor

@giunatale giunatale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a verification error in msg_participate_test.go (github reporting this)
auction.GetAllowedBidders undefined (type "github.com/tendermint/fundraising/x/fundraising/types".AuctionI has no field or method GetAllowedBidders)

Also, did we check the impact of removing our simulations wrt the ones defined in fundraising? Especially for create, which was made ad-hoc for our simulation use-cases

@lumtis
Copy link
Contributor Author

lumtis commented May 9, 2022

We have a verification error in msg_participate_test.go (github reporting this)
auction.GetAllowedBidders undefined (type "github.com/tendermint/fundraising/x/fundraising/types".AuctionI has no field or method GetAllowedBidders)

Yes, actually. I was assuming that errors were due to listen tcp 0.0.0.0:45545: bind: address already in use 🤦‍♂️ Which we are getting more and more

Also, did we check the impact of removing our simulations wrt the ones defined in fundraising? Especially for create, which was made ad-hoc for our simulation use-cases

We get successful simulations of MsgParticipate and MsgWithdrawAllocations with simulations defined in fundraising

@codecov
Copy link

codecov bot commented May 9, 2022

Codecov Report

Merging #771 (39ce4df) into develop (ff51a17) will decrease coverage by 0.23%.
The diff coverage is 5.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #771      +/-   ##
===========================================
- Coverage    11.27%   11.03%   -0.24%     
===========================================
  Files          281      282       +1     
  Lines        64146    66452    +2306     
===========================================
+ Hits          7233     7335     +102     
- Misses       56742    58942    +2200     
- Partials       171      175       +4     
Impacted Files Coverage Δ
x/campaign/types/events.pb.go 0.54% <0.54%> (ø)
x/campaign/keeper/msg_add_shares.go 77.77% <53.57%> (-15.84%) ⬇️
x/campaign/keeper/msg_unredeem_vouchers.go 63.15% <53.84%> (-3.51%) ⬇️
x/campaign/keeper/msg_add_vesting_options.go 82.14% <100.00%> (+7.14%) ⬆️
x/campaign/keeper/msg_burn_vouchers.go 72.72% <100.00%> (+4.87%) ⬆️
x/campaign/keeper/msg_create_campaign.go 84.21% <100.00%> (+2.39%) ⬆️
x/campaign/keeper/msg_edit_campaign.go 100.00% <100.00%> (ø)
x/campaign/keeper/msg_initialize_mainnet.go 94.23% <100.00%> (+0.75%) ⬆️
x/campaign/keeper/msg_mint_vouchers.go 73.33% <100.00%> (+4.91%) ⬆️
x/campaign/keeper/msg_redeem_vouchers.go 89.65% <100.00%> (+3.29%) ⬆️
... and 3 more

@aljo242 aljo242 merged commit fcbd28e into develop May 9, 2022
@aljo242 aljo242 deleted the chore/fundraising3 branch May 9, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade fundraising to 0.3.0
3 participants