-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upgrade fundraising
to 0.3.0
#771
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a verification error in msg_participate_test.go
(github reporting this)
auction.GetAllowedBidders undefined (type "github.com/tendermint/fundraising/x/fundraising/types".AuctionI has no field or method GetAllowedBidders)
Also, did we check the impact of removing our simulations wrt the ones defined in fundraising
? Especially for create
, which was made ad-hoc for our simulation use-cases
Yes, actually. I was assuming that errors were due to
We get successful simulations of |
Codecov Report
@@ Coverage Diff @@
## develop #771 +/- ##
===========================================
- Coverage 11.27% 11.03% -0.24%
===========================================
Files 281 282 +1
Lines 64146 66452 +2306
===========================================
+ Hits 7233 7335 +102
- Misses 56742 58942 +2200
- Partials 171 175 +4
|
fundraising
import version to0.3.0
participation
asfundraising
now implements its own simulations